Welcome to the forum. That is good question about the tin cup. I never been to Shiloh but hope to one day. I have tried to find out what happened to the cup but no information as of yet. Maybe some Shiloh experts on forum would know.
The cup would be prize possession for any museum or person who collects Civil War things.
Since it was likely only a regulation U.S. tin cup as pictured in Troiani's painting, there would've been absolutely NO way to identify it after his death and I imagine there was a LOT more on everyone's mind at the time!
I was resding an account of Shiloh and General Johnston saluting with his tin cup. The account I read said Colonel Statham's brigade was hesitant to advance. After Governor Harris failed to rally them, Gen Johnston rode over and touched their bayonets with his cup.
What is the true story of this event??